Fix metric-blocklist for datacenter_info, service_info, and last_successful_response #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only checking the blocklist won't chagne existing behavior with allowlists
The datacentercache is only used for building the `fastly_rt_datacenter_info` so if that mertic is in the blocklist we can safely disable the cache and the gatherer
* New TokenRecorder with Gatherer and Set methods * New gauge metric: fastly_rt_token_expiration also: go mod tidy
crivera-fastly
approved these changes
Apr 18, 2024
Add Token Expiration gauge metric
This was referenced Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
To ensure that this change is does not break existing implementations, it only supports adding these "meta" metrics to the blocklist. Otherwise any users with an existing allowlist would no longer see those metrics.
Usage example: